Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop cylc validate swallowing useful errors #4936

Merged
merged 5 commits into from
Jun 29, 2022

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jun 27, 2022

This is a small change with no associated Issue:

Fix incorrect error messages.

> touch flow.cylc
> touch suite.rc
> cylc install      # Correct error message
WorkflowFilesError: Both flow.cylc and suite.rc files are present....
> cylc validate .      # Wrong error message
WorkflowFilesError: No flow.cylc or suite.rc in .
> cylc config .
WorkflowFilesError: No flow.cylc or suite.rc in .

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@wxtim wxtim force-pushed the bugfix.repair-swallowed-exception branch from 59ff61f to 024eb17 Compare June 27, 2022 14:53
@wxtim wxtim requested review from MetRonnie and hjoliver June 27, 2022 14:54
@wxtim wxtim self-assigned this Jun 27, 2022
@wxtim wxtim added this to the cylc-8.0.0 milestone Jun 27, 2022
@MetRonnie MetRonnie modified the milestones: cylc-8.0.0, cylc-8.0rc4 Jun 27, 2022
@MetRonnie MetRonnie added bug Something is wrong :( small labels Jun 27, 2022
CHANGES.md Outdated Show resolved Hide resolved
wxtim and others added 3 commits June 28, 2022 09:59
Co-authored-by: Hilary James Oliver <[email protected]>
…cylc into bugfix.repair-swallowed-exception

* 'bugfix.repair-swallowed-exception' of github.com:wxtim/cylc:
  Update CHANGES.md
@wxtim wxtim requested a review from MetRonnie June 28, 2022 09:09
CHANGES.md Outdated Show resolved Hide resolved
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion above

Co-authored-by: Ronnie Dutta <[email protected]>
@wxtim wxtim merged commit 73cef83 into cylc:master Jun 29, 2022
@wxtim wxtim deleted the bugfix.repair-swallowed-exception branch June 29, 2022 13:55
wxtim added a commit to wxtim/cylc that referenced this pull request Jul 4, 2022
* master: (30 commits)
  Log dir tidy (cylc#4836)
  Cut down on back-compat warnings, plus other tidying (cylc#4943)
  Validate platform settings (background job runner) (cylc#4938)
  clean: push error message to stderr
  Update cylc/flow/id_match.py
  Fix unintended directory stripping during cylc install (cylc#4931)
  stop cylc validate swallowing useful errors (cylc#4936)
  Improve config reference docs (cylc#4916)
  glblcfg: increase default rolling archive length
  Fix job state with pre-submitted failure
  Update tests/functional/cylc-reinstall/02-failures.t
  reinstall: require workflow ID argument
  play: upgrade --start-task's specified in legacy format (cylc#4925)
  expand schema docstring internally (cylc#4926)
  Added a new task filtering test.
  Add comment [skip ci]
  Fix optparse Options class for std options (cylc#4919)
  uid: warn if the run number is provided as a cycle
  Tweak prev.
  Fix task filtering.
  ...
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants